linux-kernel - Re: [PATCH v1 1/1] gpiolib: sysfs: Do unexport GPIO when user asks for it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VdLuj1UZB+UqfvkrBUreT6NdFY5xrXASncinj-_XVqEbA@mail.gmail.com>
Date:   Mon, 14 Aug 2023 19:28:36 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Bartosz Golaszewski <brgl@...ev.pl>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        Linus Walleij <linus.walleij@...aro.org>,
        Andy Shevchenko <andy@...nel.org>,
        Marek Behún <kabel@...nel.org>
Subject: Re: [PATCH v1 1/1] gpiolib: sysfs: Do unexport GPIO when user asks
 for it

On Mon, Aug 14, 2023 at 7:13 PM Bartosz Golaszewski <brgl@...ev.pl> wrote:
> On Mon, Aug 14, 2023 at 1:19 PM Andy Shevchenko
> <andriy.shevchenko@...ux.intel.com> wrote:
> >
> > It seems that sysfs interface implicitly relied on the gpiod_free()
> > to unexport the line. This is not good and prone to regressions.
> > Fix it by explicitly calling gpiod_unexport().
> >
>
> I wouldn't say it's prone to regressions, it's literally just that
> gpiod_free() should not deal with sysfs.
>
> How about that for commit message (I can change it when applying):
>
> It seems that sysfs interface implicitly relied on the gpiod_free()
> to unexport the line. This is logically incorrect as core gpiolib should
> not deal with sysfs so instead of restoring it, let's call gpiod_unexport()
> from sysfs code.

I'm fine with it, go ahead and apply with the change. Thank you!

-- 
With Best Regards,
Andy Shevchenko