[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <98f8dbed-5eb9-8b09-1868-5dda4162b9e3@intel.com>
Date: Mon, 14 Aug 2023 10:49:02 -0700
From: Reinette Chatre <reinette.chatre@...el.com>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
Shuah Khan <skhan@...uxfoundation.org>,
<linux-kselftest@...r.kernel.org>, Shuah Khan <shuah@...nel.org>,
Maciej Wieczor-Retman <maciej.wieczor-retman@...el.com>,
Fenghua Yu <fenghua.yu@...el.com>,
<linux-kernel@...r.kernel.org>
CC: Shaopeng Tan <tan.shaopeng@...fujitsu.com>
Subject: Re: [PATCH 2/7] selftests/resctrl: Correct benchmark command help
Hi Ilpo,
On 8/8/2023 2:16 AM, Ilpo Järvinen wrote:
> Benchmark command must be the last argument because it consumes all the
> remaining arguments but help misleadingly shows it as the first
> argument. The benchmark command is also shown in quotes but it does not
> match with the code.
>
> Correct -b argument place in the help message and remove the quotes.
> Tweak also how the options are presented by using ... notation.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
> ---
> tools/testing/selftests/resctrl/resctrl_tests.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/resctrl/resctrl_tests.c b/tools/testing/selftests/resctrl/resctrl_tests.c
> index eef9e02516ad..559868b16079 100644
> --- a/tools/testing/selftests/resctrl/resctrl_tests.c
> +++ b/tools/testing/selftests/resctrl/resctrl_tests.c
> @@ -52,7 +52,7 @@ int get_vendor(void)
>
> static void cmd_help(void)
> {
> - printf("usage: resctrl_tests [-h] [-b \"benchmark_cmd [options]\"] [-t test list] [-n no_of_bits]\n");
> + printf("usage: resctrl_tests [-h] [-t test list] [-n no_of_bits] [-b benchmark_cmd [option]...]\n");
> printf("\t-b benchmark_cmd [options]: run specified benchmark for MBM, MBA and CMT\n");
Considering it was documented goal of patch to use "..." notation, should
it be done consistently by changing above line also?
> printf("\t default benchmark is builtin fill_buf\n");
> printf("\t-t test list: run tests specified in the test list, ");
Reinette
Powered by blists - more mailing lists