linux-kernel - Re: [PATCH 4/7] selftests/resctrl: Simplify span lifetime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 14 Aug 2023 10:49:54 -0700
From:   Reinette Chatre <reinette.chatre@...el.com>
To:     Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
        Shuah Khan <skhan@...uxfoundation.org>,
        <linux-kselftest@...r.kernel.org>, Shuah Khan <shuah@...nel.org>,
        Maciej Wieczor-Retman <maciej.wieczor-retman@...el.com>,
        Fenghua Yu <fenghua.yu@...el.com>,
        <linux-kernel@...r.kernel.org>
CC:     Shaopeng Tan <tan.shaopeng@...fujitsu.com>
Subject: Re: [PATCH 4/7] selftests/resctrl: Simplify span lifetime

Hi Ilpo,

On 8/8/2023 2:16 AM, Ilpo Järvinen wrote:
> struct resctrl_val_param contains span member. resctrl_val(), however,
> never uses it because the value of span is embedded into the default
> benchmark command and parsed from it by run_benchmark().
> 
> Remove span from resctrl_val_param. Provide DEFAULT_SPAN for the code
> that needs it. CMT and CAT tests communicate span that is different
> from the DEFAULT_SPAN between their internal functions which is
> converted into passing it directly as a parameter.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>

If I understand correctly the custom benchmark has always been
required to operate on the same span as the default benchmark in
order for the results to be measured accurately.

Thank you for eliminating unnecessary code.

Reviewed-by: Reinette Chatre <reinette.chatre@...el.com>

Reinette