linux-kernel - Re: [PATCH] drm/amd/pm: Clean up errors in amdgpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADnq5_Mmzv0-UmRX5fowsg6AOBmBvsWPjm2FSHmxL4oLF_MVDg@mail.gmail.com>
Date:   Mon, 14 Aug 2023 13:53:14 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     Ran Sun <sunran001@...suo.com>
Cc:     alexander.deucher@....com, dri-devel@...ts.freedesktop.org,
        amd-gfx@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/amd/pm: Clean up errors in amdgpu_smu.h

Applied.  Thanks!

On Mon, Jul 31, 2023 at 5:30 AM Ran Sun <sunran001@...suo.com> wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: open brace '{' following enum go on the same line
> ERROR: open brace '{' following struct go on the same line
>
> Signed-off-by: Ran Sun <sunran001@...suo.com>
> ---
>  drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 36 +++++++------------
>  1 file changed, 12 insertions(+), 24 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h b/drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h
> index 6e2069dcb6b9..190a90b24d74 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h
> +++ b/drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h
> @@ -200,29 +200,25 @@ struct smu_power_state {
>         struct smu_hw_power_state                     hardware;
>  };
>
> -enum smu_power_src_type
> -{
> +enum smu_power_src_type {
>         SMU_POWER_SOURCE_AC,
>         SMU_POWER_SOURCE_DC,
>         SMU_POWER_SOURCE_COUNT,
>  };
>
> -enum smu_ppt_limit_type
> -{
> +enum smu_ppt_limit_type {
>         SMU_DEFAULT_PPT_LIMIT = 0,
>         SMU_FAST_PPT_LIMIT,
>  };
>
> -enum smu_ppt_limit_level
> -{
> +enum smu_ppt_limit_level {
>         SMU_PPT_LIMIT_MIN = -1,
>         SMU_PPT_LIMIT_CURRENT,
>         SMU_PPT_LIMIT_DEFAULT,
>         SMU_PPT_LIMIT_MAX,
>  };
>
> -enum smu_memory_pool_size
> -{
> +enum smu_memory_pool_size {
>      SMU_MEMORY_POOL_SIZE_ZERO   = 0,
>      SMU_MEMORY_POOL_SIZE_256_MB = 0x10000000,
>      SMU_MEMORY_POOL_SIZE_512_MB = 0x20000000,
> @@ -282,8 +278,7 @@ struct smu_clock_info {
>         uint32_t max_bus_bandwidth;
>  };
>
> -struct smu_bios_boot_up_values
> -{
> +struct smu_bios_boot_up_values {
>         uint32_t                        revision;
>         uint32_t                        gfxclk;
>         uint32_t                        uclk;
> @@ -305,8 +300,7 @@ struct smu_bios_boot_up_values
>         uint32_t                        firmware_caps;
>  };
>
> -enum smu_table_id
> -{
> +enum smu_table_id {
>         SMU_TABLE_PPTABLE = 0,
>         SMU_TABLE_WATERMARKS,
>         SMU_TABLE_CUSTOM_DPM,
> @@ -326,8 +320,7 @@ enum smu_table_id
>         SMU_TABLE_COUNT,
>  };
>
> -struct smu_table_context
> -{
> +struct smu_table_context {
>         void                            *power_play_table;
>         uint32_t                        power_play_table_size;
>         void                            *hardcode_pptable;
> @@ -390,8 +383,7 @@ struct smu_power_context {
>  };
>
>  #define SMU_FEATURE_MAX        (64)
> -struct smu_feature
> -{
> +struct smu_feature {
>         uint32_t feature_num;
>         DECLARE_BITMAP(supported, SMU_FEATURE_MAX);
>         DECLARE_BITMAP(allowed, SMU_FEATURE_MAX);
> @@ -416,21 +408,18 @@ struct mclock_latency_table {
>         struct mclk_latency_entries  entries[MAX_REGULAR_DPM_NUM];
>  };
>
> -enum smu_reset_mode
> -{
> +enum smu_reset_mode {
>      SMU_RESET_MODE_0,
>      SMU_RESET_MODE_1,
>      SMU_RESET_MODE_2,
>  };
>
> -enum smu_baco_state
> -{
> +enum smu_baco_state {
>         SMU_BACO_STATE_ENTER = 0,
>         SMU_BACO_STATE_EXIT,
>  };
>
> -struct smu_baco_context
> -{
> +struct smu_baco_context {
>         uint32_t state;
>         bool platform_support;
>         bool maco_support;
> @@ -478,8 +467,7 @@ struct stb_context {
>
>  #define WORKLOAD_POLICY_MAX 7
>
> -struct smu_context
> -{
> +struct smu_context {
>         struct amdgpu_device            *adev;
>         struct amdgpu_irq_src           irq_source;
>
> --
> 2.17.1
>