[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ae50edf0-8c3a-97c5-32da-25118f36066f@quicinc.com>
Date: Tue, 15 Aug 2023 00:48:54 +0530
From: Dikshita Agarwal <quic_dikshita@...cinc.com>
To: Konrad Dybcio <konrad.dybcio@...aro.org>,
Vikash Garodia <quic_vgarodia@...cinc.com>,
<stanimir.k.varbanov@...il.com>, <agross@...nel.org>,
<andersson@...nel.org>, <mchehab@...nel.org>,
<hans.verkuil@...co.com>, <linux-kernel@...r.kernel.org>,
<linux-media@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>
Subject: Re: [PATCH 16/33] iris: add helpers for media format
On 7/28/2023 11:25 PM, Konrad Dybcio wrote:
> On 28.07.2023 15:23, Vikash Garodia wrote:
>> From: Dikshita Agarwal <quic_dikshita@...cinc.com>
>>
>> Add helpers to calculate stride, scanline, buffer size
>> etc. for different media formats.
>>
>> Signed-off-by: Dikshita Agarwal <quic_dikshita@...cinc.com>
>> Signed-off-by: Vikash Garodia <quic_vgarodia@...cinc.com>
>> ---
> [...]
>
>
>> +
>> +#ifndef MSM_MEDIA_ALIGN
>> +#define MSM_MEDIA_ALIGN(__sz, __align) (((__align) & ((__align) - 1)) ?\
>> + ((((__sz) + (__align) - 1) / (__align)) * (__align)) :\
>> + (((__sz) + (__align) - 1) & (~((__align) - 1))))
> <linux/align.h>?
>
sure, will replace with standard ALIGN macro
>> +#endif
>> +
>> +#ifndef MSM_MEDIA_ROUNDUP
>> +#define MSM_MEDIA_ROUNDUP(__sz, __r) (((__sz) + ((__r) - 1)) / (__r))
>> +#endif
>> +
>> +/*
>> + * Function arguments:
>> + * @v4l2_fmt
>> + * @width
>> + * Progressive: width
>> + * Interlaced: width
>> + */
> Kerneldoc would be cooler
>
Sure, will take care of this in next version.
> [...]
>
>> +static inline unsigned int video_rgb_stride_pix(unsigned int colorformat,
>> + unsigned int width)
>> +{
>> + unsigned int bpp = 4;
> Always?
Will check more on this if all supported RGB formats have bpp as 4.
Thanks,
Dikshita
>
>
> Konrad
Powered by blists - more mailing lists