lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f01040be-dfa5-fe60-fba5-410fccc1d50e@acm.org>
Date:   Mon, 14 Aug 2023 12:31:31 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     Brian Masney <bmasney@...hat.com>, jejb@...ux.ibm.com,
        martin.petersen@...cle.com
Cc:     alim.akhtar@...sung.com, avri.altman@....com,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        hugo@...ovil.com, quic_nguyenb@...cinc.com
Subject: Re: [PATCH v3 1/2] scsi: ufs: core: convert to dev_err_probe() in
 hba_init

On 8/14/23 11:43, Brian Masney wrote:
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> index 129446775796..409d176542e1 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -9235,8 +9235,9 @@ static int ufshcd_variant_hba_init(struct ufs_hba *hba)
>   
>   	err = ufshcd_vops_init(hba);
>   	if (err)
> -		dev_err(hba->dev, "%s: variant %s init failed err %d\n",
> -			__func__, ufshcd_get_var_name(hba), err);
> +		dev_err_probe(hba->dev, err,
> +			      "%s: variant %s init failed err %d\n",
> +			      __func__, ufshcd_get_var_name(hba), err);
>   out:
>   	return err;
>   }

This opportunity could have been used to improve the grammar of the reported
error message. Anyway:

Reviewed-by: Bart Van Assche <bvanassche@....org>

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ