[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4e745c2a-57bd-45da-8bd2-ee1cb2bab84f@lunn.ch>
Date: Mon, 14 Aug 2023 22:39:55 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Sriranjani P <sriranjani.p@...sung.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
pabeni@...hat.com, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
richardcochran@...il.com, alexandre.torgue@...s.st.com,
joabreu@...opsys.com, mcoquelin.stm32@...il.com,
alim.akhtar@...sung.com, linux-fsd@...la.com,
pankaj.dubey@...sung.com, swathi.ks@...sung.com,
ravi.patel@...sung.com, netdev@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-samsung-soc@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v3 1/4] dt-bindings: net: Add FSD EQoS device tree
bindings
> + fsd-rx-clock-skew:
> + $ref: /schemas/types.yaml#/definitions/phandle-array
> + items:
> + - items:
> + - description: phandle to the syscon node
> + - description: offset of the control register
> + description:
> + Should be phandle/offset pair. The phandle to the syscon node.
What clock are you skew-ing here? And why?
> + ethernet_1: ethernet@...00000 {
> + compatible = "tesla,dwc-qos-ethernet-4.21";
> + reg = <0x0 0x14300000 0x0 0x10000>;
> + interrupts = <GIC_SPI 176 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&clock_peric PERIC_EQOS_TOP_IPCLKPORT_CLK_PTP_REF_I>,
> + <&clock_peric PERIC_EQOS_TOP_IPCLKPORT_ACLK_I>,
> + <&clock_peric PERIC_EQOS_TOP_IPCLKPORT_HCLK_I>,
> + <&clock_peric PERIC_EQOS_TOP_IPCLKPORT_RGMII_CLK_I>,
> + <&clock_peric PERIC_EQOS_TOP_IPCLKPORT_CLK_RX_I>,
> + <&clock_peric PERIC_BUS_D_PERIC_IPCLKPORT_EQOSCLK>,
> + <&clock_peric PERIC_BUS_P_PERIC_IPCLKPORT_EQOSCLK>,
> + <&clock_peric PERIC_EQOS_PHYRXCLK_MUX>,
> + <&clock_peric PERIC_EQOS_PHYRXCLK>,
> + <&clock_peric PERIC_DOUT_RGMII_CLK>;
> + clock-names = "ptp_ref",
> + "master_bus",
> + "slave_bus",
> + "tx",
> + "rx",
> + "master2_bus",
> + "slave2_bus",
> + "eqos_rxclk_mux",
> + "eqos_phyrxclk",
> + "dout_peric_rgmii_clk";
> + pinctrl-names = "default";
> + pinctrl-0 = <ð1_tx_clk>, <ð1_tx_data>, <ð1_tx_ctrl>,
> + <ð1_phy_intr>, <ð1_rx_clk>, <ð1_rx_data>,
> + <ð1_rx_ctrl>, <ð1_mdio>;
> + fsd-rx-clock-skew = <&sysreg_peric 0x10>;
> + iommus = <&smmu_peric 0x0 0x1>;
> + phy-mode = "rgmii";
I know it is just an example, but "rgmii" is generally
wrong. "rgmii-id" is generally what you need. And when i do see
"rgmii", it starts ringing alarm bells for me, it could mean your
RGMII delays are being handled wrongly.
Andrew
Powered by blists - more mailing lists