[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAF6AEGvFHDv47DMeLTVjp5wepuvCpQrNu7a_ijifhUUcsT30tg@mail.gmail.com>
Date: Mon, 14 Aug 2023 13:59:07 -0700
From: Rob Clark <robdclark@...il.com>
To: Konrad Dybcio <konrad.dybcio@...aro.org>
Cc: Abhinav Kumar <quic_abhinavk@...cinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
Sean Paul <sean@...rly.run>, David Airlie <airlied@...il.com>,
Daniel Vetter <daniel@...ll.ch>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Marijn Suijten <marijn.suijten@...ainline.org>,
linux-arm-msm@...r.kernel.org, dri-devel@...ts.freedesktop.org,
freedreno@...ts.freedesktop.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org,
Neil Armstrong <neil.armstrong@...aro.org>
Subject: Re: [PATCH v2 08/14] drm/msm/a6xx: Add skeleton A7xx support
On Tue, Aug 8, 2023 at 2:03 PM Konrad Dybcio <konrad.dybcio@...aro.org> wrote:
>
> diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.h b/drivers/gpu/drm/msm/adreno/adreno_gpu.h
> index 49f38edf9854..3e69ef9dde3f 100644
> --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.h
> +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.h
> @@ -46,6 +46,7 @@ enum adreno_family {
> ADRENO_6XX_GEN2, /* a640 family */
> ADRENO_6XX_GEN3, /* a650 family */
> ADRENO_6XX_GEN4, /* a660 family */
> + ADRENO_7XX_GEN1, /* a730 family */
> };
>
> #define ADRENO_QUIRK_TWO_PASS_USE_WFI BIT(0)
> @@ -401,6 +402,17 @@ static inline int adreno_is_a640_family(const struct adreno_gpu *gpu)
> return gpu->info->family == ADRENO_6XX_GEN2;
> }
>
> +static inline int adreno_is_a730(struct adreno_gpu *gpu)
> +{
> + return gpu->info->chip_ids[0] == 0x07030001;
> +}
> +
> +static inline int adreno_is_a7xx(struct adreno_gpu *gpu)
> +{
> + /* Update with non-fake (i.e. non-A702) Gen 7 GPUs */
> + return adreno_is_a730(gpu);
just use the family enum here.. that lets you move the
adreno_is_a730() helper into the patch that actually adds a730
BR,
-R
> +}
> +
Powered by blists - more mailing lists