linux-kernel - Re: [PATCH] dt-bindings: remoteproc: pru: Add Interrupt property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230814-circus-preachy-b5b9f6ad07d0@wendy>
Date:   Mon, 14 Aug 2023 07:59:51 +0100
From:   Conor Dooley <conor.dooley@...rochip.com>
To:     Md Danish Anwar <a0501179@...com>
CC:     Conor Dooley <conor@...nel.org>,
        MD Danish Anwar <danishanwar@...com>,
        Suman Anna <s-anna@...com>, Conor Dooley <conor+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        Bjorn Andersson <andersson@...nel.org>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-remoteproc@...r.kernel.org>, <linux-omap@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <vigneshr@...com>,
        <srk@...com>, <nm@...com>
Subject: Re: [PATCH] dt-bindings: remoteproc: pru: Add Interrupt property

On Mon, Aug 14, 2023 at 10:43:58AM +0530, Md Danish Anwar wrote:
> On 11/08/23 8:51 pm, Conor Dooley wrote:
> > On Fri, Aug 11, 2023 at 04:48:28PM +0530, Md Danish Anwar wrote:
> > 
> >>>> There are no standard defines for these interrupt types. However I can create a
> >>>> new .h file defining all the three interrupt cells and their values for both
> >>>> PRU and RTU cores if you think that is required. Otherwise we can go with
> >>>> hardcoded values.
> >>>>
> >>>> Please let me know what you think should be done here.
> >>>
> >>> It'd be good to reference to the documentation for the cells, I don't
> >>> think adding a header is necessary here.
> >>>
> >>
> >> How should I reference to the documentation for the cells?
> >>
> >> Should I just add the details of cells in description of interrupt property here.
> >>
> >>   interrupts:
> >>     maxItems: 1
> >>     description:
> >>       Interrupt specifiers enable the virtio/rpmsg communication between MPU
> >>       and the PRU/RTU cores. The value of the interrupts should be the PRU
> >>       System event number [cell 1], PRU channel [cell 2] and PRU host_event
> >>       (target) [cell 3].
> >>
> >> Please let me know if this looks OK to you.
> > 
> > I was thinking there'd be an binding for the interrupt controller that
> > you could mentioned.
> 
> There is a binding for interrupt-controller [1] that I can mention. I tried using
> 
> - $ref: /schemas/interrupt-controller/ti,pruss-intc.yaml#
> 
> But it was throwing dt binding errors so I didn't add the ref.

Yeah, you're not a pruss-itc so that makes sense.

> 
> I will mention this file name in the description of the property like below,
> 
>      description:
>        Interrupt specifiers enable the virtio/rpmsg communication between MPU
>        and the PRU/RTU cores. For the values of the interrupt cells please
>        refer to interrupt-controller/ti,pruss-intc.yaml schema.
> 
> Please let me know if this looks OK to you.

This is what I would've expected, yea

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)