linux-kernel - Re: FW: [PATCH] platform/x86/siemens: simatic-ipc: fix nonsensical condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <075ff937-645e-41fe-87cd-0fa878dd6408@app.fastmail.com>
Date:   Mon, 14 Aug 2023 09:40:04 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "xingtong.wu" <xingtong_wu@....com>
Cc:     "xingtong.wu" <xingtong.wu@...mens.com>,
        Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
        "Arnd Bergmann" <arnd@...nel.org>,
        "Hans de Goede" <hdegoede@...hat.com>,
        "Mark Gross" <markgross@...nel.org>,
        "Nathan Chancellor" <nathan@...nel.org>,
        "Nick Desaulniers" <ndesaulniers@...gle.com>,
        "Tom Rix" <trix@...hat.com>,
        "Andy Shevchenko" <andriy.shevchenko@...ux.intel.com>,
        "Lee Jones" <lee@...nel.org>, platform-driver-x86@...r.kernel.org,
        linux-kernel@...r.kernel.org, llvm@...ts.linux.dev,
        gerd.haeussler.ext@...mens.com, tobias.schaffner@...mens.com
Subject: Re: FW: [PATCH] platform/x86/siemens: simatic-ipc: fix nonsensical condition

On Mon, Aug 14, 2023, at 05:40, xingtong.wu wrote:
>>From: Arnd Bergmann <arnd@...db.de> 
>
>>Sent: Friday, August 11, 2023 11:02 PM
>>
>>Ok, I see. I missed those as there is hasn't been a new linux-next in a few days.
>>
>>I suppose this one is also fixed then?
>>
>>WARNING: unmet direct dependencies detected for P2SB
>>  Depends on [n]: PCI [=n] && X86 [=y]
>>  Selected by [m]:
>>  - SIEMENS_SIMATIC_IPC_WDT [=m] && WATCHDOG [=y] && SIEMENS_SIMATIC_IPC [=y]
>>drivers/platform/x86/p2sb.c:68:9: error: call to undeclared function 'pci_scan_single_device'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
>
> I’m pretty sure your .config file is error to compile the kernel,
> you must have changed the .config file manually, and there will be no
> possibility that option SIEMENS_SIMATIC_IPC is [y] while PCI is [n].
> reason:
> https://elixir.bootlin.com/linux/v6.5-rc6/source/drivers/platform/x86/Kconfig#L1079
>
> if the PCI option is [n], the "p2sb.c" should never compile pass.
>
> I suggest you make menuconfig to build kernel and check your .config
> carefully.

It was broken in linux-next by commit b72da71ce24b0 ("platform/x86:
simatic-ipc: drop PCI runtime depends and header"), I sent a fix now.

    Arnd