[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ab33f7c1-c488-ae3d-e968-23d8c04d18b3@linaro.org>
Date: Mon, 14 Aug 2023 10:13:33 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Gowthami Thiagarajan <gthiagarajan@...vell.com>, will@...nel.org,
mark.rutland@....com, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
devicetree@...r.kernel.org
Cc: sgoutham@...vell.com, bbhushan2@...vell.com, lcherian@...vell.com
Subject: Re: [PATCH v2 2/6] dt-bindings: perf: Add Marvell PEM performance
monitor unit
On 12/08/2023 16:25, Gowthami Thiagarajan wrote:
> Add binding documentation for Marvell PEM performance monitor unit.
>
> Signed-off-by: Linu Cherian <lcherian@...vell.com>
> Signed-off-by: Gowthami Thiagarajan <gthiagarajan@...vell.com>
> ---
>
> v1->v2
> - Changed DT binding file name to match with compatible
> - Added respective document in MAINTAINERS
>
> .../perf/marvell,odyssey-pem-pmu.yaml | 38 +++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 39 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/perf/marvell,odyssey-pem-pmu.yaml
>
> diff --git a/Documentation/devicetree/bindings/perf/marvell,odyssey-pem-pmu.yaml b/Documentation/devicetree/bindings/perf/marvell,odyssey-pem-pmu.yaml
> new file mode 100644
> index 000000000000..a761fc09565b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/perf/marvell,odyssey-pem-pmu.yaml
> @@ -0,0 +1,38 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/perf/marvell,odyssey-pem-pmu.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Marvell PCIe interface performance monitor
> +
> +maintainers:
> + - Linu Cherian <lcherian@...vell.com>
> + - Gowthami Thiagarajan <gthiagarajan@...vell.com>
> +
> +properties:
> + compatible:
> + items:
Drop items, you have just enum.
> + - enum:
> + - marvell,odyssey-pem-pmu
Neither commit msg nor description in the binding (there is none!) helps
me to understand what is the SoC here. Remember: compatibles are
specific to SoCs, not families.
Best regards,
Krzysztof
Powered by blists - more mailing lists