linux-kernel - Re: [RESEND PATCH v2] drm/panel: JDI LT070ME05000 simplify with dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 14 Aug 2023 14:40:05 +0200
From:   Neil Armstrong <neil.armstrong@...aro.org>
To:     David Heidelberg <david@...t.cz>, Sam Ravnborg <sam@...nborg.org>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>
Cc:     dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH v2] drm/panel: JDI LT070ME05000 simplify with
 dev_err_probe()

On 12/08/2023 20:52, David Heidelberg wrote:
> Use the dev_err_probe() helper to simplify error handling during probe.
> This also handle scenario, when EDEFER is returned and useless error is printed.
> 
> Fixes error:
> panel-jdi-lt070me05000 4700000.dsi.0: cannot get enable-gpio -517
> 
> Signed-off-by: David Heidelberg <david@...t.cz>
> ---
> resend:
>   - applies cleanly on -next
> v2:
>   - original v1 patch name "drm/panel: JDI LT070ME05000 remove useless warning"
>   - use dev_err_probe function
> 
>   .../gpu/drm/panel/panel-jdi-lt070me05000.c    | 36 ++++++++-----------
>   1 file changed, 14 insertions(+), 22 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c b/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c
> index e94c98f00391..f9a69f347068 100644
> --- a/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c
> +++ b/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c
> @@ -400,38 +400,30 @@ static int jdi_panel_add(struct jdi_panel *jdi)
>   
>   	ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(jdi->supplies),
>   				      jdi->supplies);
> -	if (ret < 0) {
> -		dev_err(dev, "failed to init regulator, ret=%d\n", ret);
> -		return ret;
> -	}
> +	if (ret < 0)
> +		return dev_err_probe(dev, ret,
> +				     "failed to init regulator, ret=%d\n", ret);
>   
>   	jdi->enable_gpio = devm_gpiod_get(dev, "enable", GPIOD_OUT_LOW);
>   	if (IS_ERR(jdi->enable_gpio)) {
> -		ret = PTR_ERR(jdi->enable_gpio);
> -		dev_err(dev, "cannot get enable-gpio %d\n", ret);
> -		return ret;
> +		return dev_err_probe(dev, PTR_ERR(jdi->enable_gpio),
> +				     "cannot get enable-gpio %d\n", ret);
>   	}
>   
>   	jdi->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH);
> -	if (IS_ERR(jdi->reset_gpio)) {
> -		ret = PTR_ERR(jdi->reset_gpio);
> -		dev_err(dev, "cannot get reset-gpios %d\n", ret);
> -		return ret;
> -	}
> +	if (IS_ERR(jdi->reset_gpio))
> +		return dev_err_probe(dev, PTR_ERR(jdi->reset_gpio),
> +				     "cannot get reset-gpios %d\n", ret);
>   
>   	jdi->dcdc_en_gpio = devm_gpiod_get(dev, "dcdc-en", GPIOD_OUT_LOW);
> -	if (IS_ERR(jdi->dcdc_en_gpio)) {
> -		ret = PTR_ERR(jdi->dcdc_en_gpio);
> -		dev_err(dev, "cannot get dcdc-en-gpio %d\n", ret);
> -		return ret;
> -	}
> +	if (IS_ERR(jdi->dcdc_en_gpio))
> +		return dev_err_probe(dev, PTR_ERR(jdi->dcdc_en_gpio),
> +				     "cannot get dcdc-en-gpio %d\n", ret);
>   
>   	jdi->backlight = drm_panel_create_dsi_backlight(jdi->dsi);
> -	if (IS_ERR(jdi->backlight)) {
> -		ret = PTR_ERR(jdi->backlight);
> -		dev_err(dev, "failed to register backlight %d\n", ret);
> -		return ret;
> -	}
> +	if (IS_ERR(jdi->backlight))
> +		return dev_err_probe(dev, PTR_ERR(jdi->backlight),
> +				     "failed to register backlight %d\n", ret);
>   
>   	drm_panel_init(&jdi->base, &jdi->dsi->dev, &jdi_panel_funcs,
>   		       DRM_MODE_CONNECTOR_DSI);

Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>