linux-kernel - Re: [PATCH AUTOSEL 5.10 22/25] rbd: make get_lock_owner

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOi1vP-+xfmQBNWL4iKC+bB-T+yjPh=zF0nBqGMeXCdvpf7+zg@mail.gmail.com>
Date:   Mon, 14 Aug 2023 15:23:41 +0200
From:   Ilya Dryomov <idryomov@...il.com>
To:     Sasha Levin <sashal@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Dongsheng Yang <dongsheng.yang@...ystack.cn>, axboe@...nel.dk,
        ceph-devel@...r.kernel.org, linux-block@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 5.10 22/25] rbd: make get_lock_owner_info() return
 a single locker or NULL

On Sun, Aug 13, 2023 at 6:11 PM Sasha Levin <sashal@...nel.org> wrote:
>
> From: Ilya Dryomov <idryomov@...il.com>
>
> [ Upstream commit f38cb9d9c2045dad16eead4a2e1aedfddd94603b ]
>
> Make the "num_lockers can be only 0 or 1" assumption explicit and
> simplify the API by getting rid of output parameters in preparation
> for calling get_lock_owner_info() twice before blocklisting.
>
> Signed-off-by: Ilya Dryomov <idryomov@...il.com>
> Reviewed-by: Dongsheng Yang <dongsheng.yang@...ystack.cn>
> Signed-off-by: Sasha Levin <sashal@...nel.org>

Hi Sasha,

This is a prerequisite patch, it doesn't make sense to backport it
without also backporting "rbd: harden get_lock_owner_info() a bit" and
"rbd: retrieve and check lock owner twice before blocklisting".

Please drop it.

Thanks,

                Ilya