linux-kernel - Re: [PATCH] wireless: ath: remove unused-but-set parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6529ca77-6ce4-d930-38a4-5ee2f9671bdd@quicinc.com>
Date:   Mon, 14 Aug 2023 07:09:00 -0700
From:   Jeff Johnson <quic_jjohnson@...cinc.com>
To:     Arnd Bergmann <arnd@...nel.org>, Kalle Valo <kvalo@...nel.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        Nick Kossifidis <mickflemm@...il.com>,
        "Luis Chamberlain" <mcgrof@...nel.org>,
        Toke Høiland-Jørgensen 
        <toke@...e.dk>
CC:     Arnd Bergmann <arnd@...db.de>,
        Nathan Chancellor <nathan@...nel.org>,
        "Nick Desaulniers" <ndesaulniers@...gle.com>,
        Tom Rix <trix@...hat.com>,
        Aloka Dixit <quic_alokad@...cinc.com>,
        Wen Gong <quic_wgong@...cinc.com>,
        "Ramya Gnanasekar" <quic_rgnanase@...cinc.com>,
        Karthik M <quic_karm@...cinc.com>,
        Aditya Kumar Singh <quic_adisi@...cinc.com>,
        Muna Sinada <quic_msinada@...cinc.com>,
        Johannes Berg <johannes.berg@...el.com>,
        <ath12k@...ts.infradead.org>, <linux-wireless@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <llvm@...ts.linux.dev>
Subject: Re: [PATCH] wireless: ath: remove unused-but-set parameter

On 8/14/2023 12:32 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> This has never been used since the driver was merged, but it now causes
> a W=1 warning in recent clang versions
> 
> drivers/net/wireless/ath/ath9k/main.c:1566:21: error: parameter 'changed_flags' set but not used [-Werror,-Wunused-but-set-parameter]
> drivers/net/wireless/ath/ath9k/htc_drv_main.c:1258:25: error: parameter 'changed_flags' set but not used [-Werror,-Wunused-but-set-parameter]
> drivers/net/wireless/ath/ath5k/mac80211-ops.c:367:62: error: parameter 'changed_flags' set but not used [-Werror,-Wunused-but-set-parameter]
> 
> Remove the bit manipulation on the otherwise unused parameter.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

I'm wondering if the ath12k change should be separated into its own 
patch because 1) it is the most current driver with a dedicated list, 
and 2) it actually doesn't generate a warning because changed_flags is 
used, just not in a meaningful way. But I'll let Kalle make the call on 
that when he returns from holiday.

Reviewed-by: Jeff Johnson <quic_jjohnson@...cinc.com>