linux-kernel - Re: [PATCH V3] scsi: ufs: qcom: Align programming sequence as per HW spec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <422d202b-2e2e-b01f-436b-bdf7c7024960@quicinc.com>
Date:   Mon, 14 Aug 2023 20:07:39 +0530
From:   Nitin Rawat <quic_nitirawa@...cinc.com>
To:     Bjorn Andersson <andersson@...nel.org>
CC:     <mani@...nel.org>, <quic_nguyenb@...cinc.com>,
        <quic_cang@...cinc.com>, <quic_asutoshd@...cinc.com>,
        <avri.altman@....com>, <martin.petersen@...cle.com>,
        <beanhuo@...ron.com>, <bvanassche@....org>,
        <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <agross@...nel.org>, <konrad.dybcio@...aro.org>,
        <jejb@...ux.ibm.com>, <linux-arm-msm@...r.kernel.org>,
        <quic_ziqichen@...cinc.com>,
        "Naveen Kumar Goud Arepalli" <quic_narepall@...cinc.com>
Subject: Re: [PATCH V3] scsi: ufs: qcom: Align programming sequence as per HW
 spec

Hi Bjorn,

I've updated the commit message in latest Patchset. Please can you help 
review.

Regards,
Nitin


On 8/10/2023 8:11 PM, Bjorn Andersson wrote:
> On Wed, Aug 09, 2023 at 08:42:43PM +0530, Nitin Rawat wrote:
>> Align clock configuration as per Qualcomm UFS controller
>> hardware specification.
>>
>> This change updates UFS_SYS1CLK_1US, CORE_CLK_1US_CYCLES,
>> PA_VS_CORE_CLK_40NS_CYCLES timer configuration for Qunipro
>> and UTP to align with Qualcomm UFS HW specification.
> 
> "Code is wrong, make code right"
> 
> 
> I find it hard to believe that "the clock configuration is wrong" takes
> 207 lines of code to address.
> 
> Please instead describe the problem you're solving, to ensure that
> current and future readers of this commit message have a chance to
> understand why this change was made.
> 
> The "describing your changes" section in the documentation is good,
> please read it:
> https://docs.kernel.org/process/submitting-patches.html#describe-your-changes
> 
> Regards,
> Bjorn