linux-kernel - Re: [PATCH 2/3] mm,thp: fix nodeN/meminfo output alignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 15 Aug 2023 19:52:48 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Hugh Dickins <hughd@...gle.com>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     Alexey Dobriyan <adobriyan@...il.com>,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH 2/3] mm,thp: fix nodeN/meminfo output alignment

On 14.08.23 22:01, Hugh Dickins wrote:
> Add one more space to FileHugePages and FilePmdMapped, so the output
> is aligned with other rows in /sys/devices/system/node/nodeN/meminfo.
> 
> Signed-off-by: Hugh Dickins <hughd@...gle.com>
> ---
>   drivers/base/node.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/base/node.c b/drivers/base/node.c
> index 9de524e56307..8e871ba9162f 100644
> --- a/drivers/base/node.c
> +++ b/drivers/base/node.c
> @@ -446,8 +446,8 @@ static ssize_t node_read_meminfo(struct device *dev,
>   			     "Node %d AnonHugePages:  %8lu kB\n"
>   			     "Node %d ShmemHugePages: %8lu kB\n"
>   			     "Node %d ShmemPmdMapped: %8lu kB\n"
> -			     "Node %d FileHugePages: %8lu kB\n"
> -			     "Node %d FilePmdMapped: %8lu kB\n"
> +			     "Node %d FileHugePages:  %8lu kB\n"
> +			     "Node %d FilePmdMapped:  %8lu kB\n"
>   #endif
>   #ifdef CONFIG_UNACCEPTED_MEMORY
>   			     "Node %d Unaccepted:     %8lu kB\n"

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 
Cheers,

David / dhildenb