linux-kernel - Re: [PATCH v2 1/3] dt-bindings: arm: qcom: add sc7180-lazor board bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAD=FV=WqFo5PFB7+7ZOQtsTLYojjTn1VkaAQpMkqvWUFPOmBQg@mail.gmail.com>
Date:   Tue, 15 Aug 2023 13:41:46 -0700
From:   Doug Anderson <dianders@...omium.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Sheng-Liang Pan <sheng-liang.pan@...nta.corp-partner.google.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: arm: qcom: add sc7180-lazor board bindings

Hi,

On Sun, Aug 6, 2023 at 11:32 PM Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> wrote:
>
> On 04/08/2023 11:58, Sheng-Liang Pan wrote:
> > Introduce more sc7180-lazor sku and board version configuration,
> > add no-eSIM SKU 10 for Lazor, no-eSIM SKU 15 and 18 for Limozeen,
> > add new board version 10 for audio codec ALC5682i-VS.
> >
> > Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@...nta.corp-partner.google.com>
> > ---
> >
> > Changes in v2:
> > - add new entry rev9 with Parade bridge chip
> >
> >  .../devicetree/bindings/arm/qcom.yaml         | 55 +++++++++++++++++++
> >  1 file changed, 55 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> > index 450f616774e0..dce7b771a280 100644
> > --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> > @@ -470,6 +470,11 @@ properties:
> >            - const: google,lazor-rev8
> >            - const: qcom,sc7180
> >
> > +      - description: Acer Chromebook Spin 513 Parade bridge chip (rev9)
> > +        items:
> > +          - const: google,lazor-rev9
> > +          - const: qcom,sc7180
> > +
> >        - description: Acer Chromebook Spin 513 (newest rev)
> >          items:
> >            - const: google,lazor
> > @@ -491,6 +496,11 @@ properties:
> >            - const: google,lazor-rev8-sku2
> >            - const: qcom,sc7180
> >
> > +      - description: Acer Chromebook Spin 513 Parade bridge chip with KB Backlight (rev9)
> > +        items:
> > +          - const: google,lazor-rev9-sku2
> > +          - const: qcom,sc7180
> > +
> >        - description: Acer Chromebook Spin 513 with KB Backlight (newest rev)
> >          items:
> >            - const: google,lazor-sku2
> > @@ -512,11 +522,26 @@ properties:
> >            - const: google,lazor-rev8-sku0
> >            - const: qcom,sc7180
> >
> > +      - description: Acer Chromebook Spin 513 Parade bridge chip with LTE (rev9)
> > +        items:
> > +          - const: google,lazor-rev9-sku0
> > +          - const: qcom,sc7180
> > +
> >        - description: Acer Chromebook Spin 513 with LTE (newest rev)
> >          items:
> >            - const: google,lazor-sku0
> >            - const: qcom,sc7180
> >
> > +      - description: Acer Chromebook Spin 513 Parade bridge chip with LTE no-esim (rev9)
> > +        items:
> > +          - const: google,lazor-rev9-sku10
> > +          - const: qcom,sc7180
> > +
> > +      - description: Acer Chromebook Spin 513 with LTE no-esim (newest rev)
> > +        items:
> > +          - const: google,lazor-sku10
> > +          - const: qcom,sc7180
> > +
> >        - description: Acer Chromebook 511 (rev4 - rev8)
> >          items:
> >            - const: google,lazor-rev4-sku4
> > @@ -526,6 +551,11 @@ properties:
> >            - const: google,lazor-rev8-sku4
> >            - const: qcom,sc7180
> >
> > +      - description: Acer Chromebook 511 Parade bridge chip (rev9)
> > +        items:
> > +          - const: google,lazor-rev9-sku4
> > +          - const: qcom,sc7180
> > +
> >        - description: Acer Chromebook 511 (newest rev)
> >          items:
> >            - const: google,lazor-sku4
> > @@ -545,11 +575,36 @@ properties:
> >            - const: google,lazor-rev8-sku6
> >            - const: qcom,sc7180
> >
> > +      - description: Acer Chromebook 511 Parade bridge chip without Touchscreen (rev9)
> > +        items:
> > +          - const: google,lazor-rev9-sku6
> > +          - const: qcom,sc7180
> > +
> >        - description: Acer Chromebook 511 without Touchscreen (newest rev)
> >          items:
> >            - const: google,lazor-sku6
> >            - const: qcom,sc7180
> >
> > +      - description: Acer Chromebook 511 Parade bridge chip no-esim (rev9)
> > +        items:
> > +          - const: google,lazor-rev9-sku15
> > +          - const: qcom,sc7180
> > +
> > +      - description: Acer Chromebook 511 no-esim (newest rev)
> > +        items:
> > +          - const: google,lazor-sku15
> > +          - const: qcom,sc7180
> > +
> > +      - description: Acer Chromebook 511 Parade bridge chip without Touchscreen no-esim (rev9)
> > +        items:
> > +          - const: google,lazor-rev9-sku18
> > +          - const: qcom,sc7180
> > +
> > +      - description: Acer Chromebook 511 without Touchscreen no-esim (newest rev)
> > +        items:
> > +          - const: google,lazor-sku18
>
> All of these entries (existing and new) should be just one entry with:
>  - enum:
>      - ....
>      - ....
>  - const: qcom,sc7180

I believe we've had this discussion before. At least twice. Here's a
link to the last time you said "Ah, OK, I guess this is fine".

https://lore.kernel.org/r/d3d4d90b-85b5-5ad9-78e6-5a074c21af4f@linaro.org