linux-kernel - Re: [PATCH v1] drivers: usb: Removes use of assignment in if condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2023081550-absurd-sprint-65e5@gregkh>
Date:   Tue, 15 Aug 2023 23:07:02 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Atul Kumar Pant <atulpant.linux@...il.com>
Cc:     richard.leitner@...ux.dev, wsa+renesas@...g-engineering.com,
        mhocko@...e.com, surenb@...gle.com, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, shuah@...nel.org
Subject: Re: [PATCH v1] drivers: usb: Removes use of assignment in if
 condition

On Wed, Aug 16, 2023 at 02:11:41AM +0530, Atul Kumar Pant wrote:
> This patch fixes following checkpatch.pl issue:
> ERROR: do not use assignment in if condition
> 
> Signed-off-by: Atul Kumar Pant <atulpant.linux@...il.com>
> ---
>  drivers/usb/core/devio.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
> index e501a03d6c70..56899fed6bd4 100644
> --- a/drivers/usb/core/devio.c
> +++ b/drivers/usb/core/devio.c
> @@ -2333,9 +2333,10 @@ static int proc_ioctl(struct usb_dev_state *ps, struct usbdevfs_ioctl *ctl)
>  		}
>  	}
>  
> +	intf = usb_ifnum_to_if(ps->dev, ctl->ifno);
>  	if (ps->dev->state != USB_STATE_CONFIGURED)
>  		retval = -EHOSTUNREACH;
> -	else if (!(intf = usb_ifnum_to_if(ps->dev, ctl->ifno)))
> +	else if (!intf)

Did you mean to change the logic here by doing the calculation always?
Does that change functionality?

The existing code is fine, running checkpatch on code outside of
drivers/staging/ or on new patches you are writing, is generally
discouraged as the code usually is older than checkpatch is :)

thanks,

greg k-h