linux-kernel - Re: [PATCH 02/10] scsi: libsas: Delete enum sas

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c42b475c-8fdc-e1cc-45d1-a693faffd4ca@kernel.org>
Date:   Tue, 15 Aug 2023 11:07:41 +0900
From:   Damien Le Moal <dlemoal@...nel.org>
To:     John Garry <john.g.garry@...cle.com>, jejb@...ux.ibm.com,
        martin.petersen@...cle.com, chenxiang66@...ilicon.com,
        artur.paszkiewicz@...el.com, yanaijie@...wei.com,
        jinpu.wang@...ud.ionos.com
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 02/10] scsi: libsas: Delete enum sas_class

On 8/14/23 23:10, John Garry wrote:
> enum sas_class prob would have been useful if function sas_show_class() was
> ever implemented, which it wasn't.
> 
> enum sas_class is used as asd_sas_port.class and asd_sas_phy.class, which
> are only ever set, so delete these members and the enum.
> 
> Signed-off-by: John Garry <john.g.garry@...cle.com>

Looks good.

Reviewed-by: Damien Le Moal <dlemoal@...nel.org>

-- 
Damien Le Moal
Western Digital Research