linux-kernel - Re: [PATCH v2] fbcon: mark fbcon_registered

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0423ff9f-f783-0986-9867-7862560b8c59@gmx.de>
Date:   Tue, 15 Aug 2023 23:34:12 +0200
From:   Helge Deller <deller@....de>
To:     Min-Hua Chen <minhuadotchen@...il.com>,
        Daniel Vetter <daniel@...ll.ch>
Cc:     linux-fbdev@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] fbcon: mark fbcon_registered_fb static

On 8/4/23 13:32, Min-Hua Chen wrote:
> Mark fbcon_registered_fb, and fbcon_num_registered_fb static
> to fix the following sparse warnings:
>
> drivers/video/fbdev/core/fbcon.c:105:16: sparse: warning: symbol 'fbcon_registered_fb' was not declared. Should it be static?
> drivers/video/fbdev/core/fbcon.c:106:5: sparse: warning: symbol 'fbcon_num_registered_fb' was not declared. Should it be static?
>
> No functional change intended.
>
> Cc: Helge Deller <deller@....de>
> Signed-off-by: Min-Hua Chen <minhuadotchen@...il.com>

applied to the for-next-6.6 branch.

Thanks,
Helge


>
> ---
>
> change since v1:
> 1. registered_fb and num_registered_fb are still used in drivers/staging/olpc_dcon,
> so do keep them as-is.
> 2. change the subject to fbcon: mark fbcon_registered_fb static
> ---
>   drivers/video/fbdev/core/fbcon.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
> index 887fad44e7ec..976900d6893c 100644
> --- a/drivers/video/fbdev/core/fbcon.c
> +++ b/drivers/video/fbdev/core/fbcon.c
> @@ -102,8 +102,8 @@ enum {
>
>   static struct fbcon_display fb_display[MAX_NR_CONSOLES];
>
> -struct fb_info *fbcon_registered_fb[FB_MAX];
> -int fbcon_num_registered_fb;
> +static struct fb_info *fbcon_registered_fb[FB_MAX];
> +static int fbcon_num_registered_fb;
>
>   #define fbcon_for_each_registered_fb(i)		\
>   	for (i = 0; WARN_CONSOLE_UNLOCKED(), i < FB_MAX; i++)		\