[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <8BF54CCD-FCCB-430A-A78E-53DC55F3C286@gmail.com>
Date: Tue, 15 Aug 2023 10:32:30 +0800
From: Mining Lin <mimi05633@...il.com>
To: Paul Menzel <pmenzel@...gen.mpg.de>
Cc: avifishman70@...il.com, tmaimon77@...il.com, tali.perry1@...il.com,
venture@...gle.com, yuenn@...gle.com, benjaminfair@...gle.com,
a.zummo@...ertech.it, alexandre.belloni@...tlin.com,
robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
conor+dt@...nel.org, KWLIU@...oton.com, JJLIU0@...oton.com,
KFLIN@...oton.com, mylin1@...oton.com, linux-rtc@...r.kernel.org,
devicetree@...r.kernel.org, openbmc@...ts.ozlabs.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: rtc: nuvoton: Add DT compatible
Dear Paul,
Thank you for your comments.
I originally wanted to judge whether to match chip data by DT compatible, but it does not make sense.
Therefore, I will remove it in the v4 version.
Thanks.
Best regard,
Mia
> On Aug 10, 2023, at 3:55 PM, Paul Menzel <pmenzel@...gen.mpg.de> wrote:
>
> Dear Mia,
>
>
> Thank you for your patch. It’d be great if you mentioned nct3015y in the commit message summary/title. Maybe:
>
> dt-bindings: rtc: Add compatible nct3015y to nuvoton,nct3018y
>
>> Am 09.08.23 um 11:51 schrieb Mia Lin:
>> Add DT compatible "nuvoton,nct3015y" to select
>
> What do you mean by “to select”?
>
> Also, maybe add how you tested this.
>
>> Signed-off-by: Mia Lin <mimi05633@...il.com>
>> ---
>> Documentation/devicetree/bindings/rtc/nuvoton,nct3018y.yaml | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>> diff --git a/Documentation/devicetree/bindings/rtc/nuvoton,nct3018y.yaml b/Documentation/devicetree/bindings/rtc/nuvoton,nct3018y.yaml
>> index 4f9b5604acd9..67fc60fd395c 100644
>> --- a/Documentation/devicetree/bindings/rtc/nuvoton,nct3018y.yaml
>> +++ b/Documentation/devicetree/bindings/rtc/nuvoton,nct3018y.yaml
>> @@ -15,7 +15,9 @@ maintainers:
>> properties:
>> compatible:
>> - const: nuvoton,nct3018y
>> + enum:
>> + - nuvoton,nct3018y
>> + - nuvoton,nct3015y
>
> Would sorting the list be useful?
>
>> reg:
>> maxItems: 1
>
>
> Kind regards,
>
> Paul
Powered by blists - more mailing lists