[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <bbf1e081-7732-d2f8-6490-215947eed5d3@linux.alibaba.com>
Date: Tue, 15 Aug 2023 10:57:29 +0800
From: Baolin Wang <baolin.wang@...ux.alibaba.com>
To: Kemeng Shi <shikemeng@...weicloud.com>, linux-mm@...ck.org,
linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
mgorman@...hsingularity.net, david@...hat.com, willy@...radead.org
Subject: Re: [PATCH] mm/compaction: remove unused parameter pgdata of
fragmentation_score_wmark
On 8/9/2023 5:49 PM, Kemeng Shi wrote:
> Parameter pgdat is not used in fragmentation_score_wmark. Just remove it.
>
> Signed-off-by: Kemeng Shi <shikemeng@...weicloud.com>
Reviewed-by: Baolin Wang <baolin.wang@...ux.alibaba.com>
> ---
> mm/compaction.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/mm/compaction.c b/mm/compaction.c
> index ea61922a1619..38c8d216c6a3 100644
> --- a/mm/compaction.c
> +++ b/mm/compaction.c
> @@ -2142,7 +2142,7 @@ static unsigned int fragmentation_score_node(pg_data_t *pgdat)
> return score;
> }
>
> -static unsigned int fragmentation_score_wmark(pg_data_t *pgdat, bool low)
> +static unsigned int fragmentation_score_wmark(bool low)
> {
> unsigned int wmark_low;
>
> @@ -2162,7 +2162,7 @@ static bool should_proactive_compact_node(pg_data_t *pgdat)
> if (!sysctl_compaction_proactiveness || kswapd_is_running(pgdat))
> return false;
>
> - wmark_high = fragmentation_score_wmark(pgdat, false);
> + wmark_high = fragmentation_score_wmark(false);
> return fragmentation_score_node(pgdat) > wmark_high;
> }
>
> @@ -2201,7 +2201,7 @@ static enum compact_result __compact_finished(struct compact_control *cc)
> return COMPACT_PARTIAL_SKIPPED;
>
> score = fragmentation_score_zone(cc->zone);
> - wmark_low = fragmentation_score_wmark(pgdat, true);
> + wmark_low = fragmentation_score_wmark(true);
>
> if (score > wmark_low)
> ret = COMPACT_CONTINUE;
Powered by blists - more mailing lists