[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20230815035145.16990-1-rohan.g.thomas@intel.com>
Date: Tue, 15 Aug 2023 11:51:45 +0800
From: Rohan G Thomas <rohan.g.thomas@...el.com>
To: Jose Abreu <joabreu@...opsys.com>
Cc: alexandre.torgue@...s.st.com, conor+dt@...nel.org,
davem@...emloft.net, devicetree@...r.kernel.org,
edumazet@...gle.com, krzysztof.kozlowski+dt@...aro.org,
kuba@...nel.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org,
linux-stm32@...md-mailman.stormreply.com,
mcoquelin.stm32@...il.com, netdev@...r.kernel.org,
pabeni@...hat.com, peppe.cavallaro@...com, robh+dt@...nel.org,
Rohan G Thomas <rohan.g.thomas@...el.com>
Subject: RE: [PATCH net-next v3 2/2] net: stmmac: Tx coe sw fallback
From: Rohan G Thomas <rohan.g.thomas@...el.com>
Date: Mon, Aug 14, 2023 at 15:06:37
> > > + bool tx_q_coe_lmt;
> >
> > Please use a flag here instead of "tx_q_coe_lmt". This is the
> > preferrable method now.
> >
> > Thanks,
> > Jose
>
> Thanks Jose for the feedback. If I read that correctly, your suggestion is to
> change " tx_q_coe_lmt" to something more readable, like "has_txcoe_limit".
> Please correct me if I understand it wrongly.
>
> BR,
> Rohan
>
Or, use int instead of bool?
BR,
Rohan
Powered by blists - more mailing lists