linux-kernel - Re: [PATCH] powerpc: powermac: Use of_get_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <874jl1dkea.fsf@mail.lhotse>
Date:   Tue, 15 Aug 2023 14:01:01 +1000
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Michael Ellerman <patch-notifications@...erman.id.au>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Nicholas Piggin <npiggin@...il.com>,
        Christophe Leroy <christophe.leroy@...roup.eu>,
        Rob Herring <robh@...nel.org>
Cc:     linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] powerpc: powermac: Use of_get_cpu_hwid() to read CPU
 node 'reg'

Christophe JAILLET <christophe.jaillet@...adoo.fr> writes:
> Le 03/07/2023 à 07:26, Michael Ellerman a écrit :
>> On Sun, 19 Mar 2023 09:59:31 -0500, Rob Herring wrote:
>>> Replace open coded reading of CPU nodes' "reg" properties with
>>> of_get_cpu_hwid() dedicated for this purpose.
>>>
>>>
>> 
>> Applied to powerpc/next.
>> 
>> [1/1] powerpc: powermac: Use of_get_cpu_hwid() to read CPU node 'reg'
>>        https://git.kernel.org/powerpc/c/bc1cf75027585f8d87f94e464ee5909acf885a8c
>> 
>> cheers
>> 
>
> Hi,
>
> I guess, that it does not really matter, but shouldn't the 
> of_node_put() be *after* the "reset_io = *rst;" statements to be 
> absolutely safe?

Technically yes.

> (This change is in my backlog and I have apparently never proposed it)

Can you rebase and resend?

cheers