linux-kernel - Re: [PATCH 2/2] Input: cs40l50 - Initial support for Cirrus Logic CS40L50

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ba958196-fb2d-f7ba-46cd-6a3cb40f21bd@linaro.org>
Date:   Tue, 15 Aug 2023 07:08:22 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     James Ogletree <James.Ogletree@...rus.com>
Cc:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Fred Treven <Fred.Treven@...rus.com>,
        Ben Bright <Ben.Bright@...rus.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>, Lee Jones <lee@...nel.org>,
        Peng Fan <peng.fan@....com>, Jean Delvare <jdelvare@...e.de>,
        Jeff LaBundy <jeff@...undy.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        Arnd Bergmann <arnd@...db.de>,
        Eddie James <eajames@...ux.ibm.com>,
        Jacky Bai <ping.bai@....com>,
        Markus Schneider-Pargmann <msp@...libre.com>,
        ChiYuan Huang <cy_huang@...htek.com>,
        Jerome Neanne <jneanne@...libre.com>,
        "patches@...rus.com" <patches@...rus.com>,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] Input: cs40l50 - Initial support for Cirrus Logic
 CS40L50

On 14/08/2023 23:44, James Ogletree wrote:

>>>> I don't think this is a module.
>>>
>>> It can be compiled as a module with CONFIG_INPUT_CS40L50=m. However, there is a
>>> typo in the Kconfig entry description: the module will be called “cs40l50” not “cs40l50-core”.
>>> That will be fixed. 
>>
>> Really, *this* unit file can be compiled as module? Where is the
>> module_xxx_driver() then?
>>
> 
> As I understand it, the “module_XXX_driver()” has nothing to do with whether or not the file is built as a module, rather it just provides code to attach the driver to a bus. But this is a bus-agnostic, separate module (not a driver in itself) that provides implementation to cs40l26-i2c or cs40l26-spi drivers, which do contain that macro as they should. This doesn’t appear to be an uncommon pattern.


I see now in the Makefile that it can be indeed built as module and
compiled on its own. It's fine then.

Best regards,
Krzysztof