linux-kernel - Re: [PATCH 07/10] scsi: libsas: Delete sas_ssp_task.task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <de5b2ba9-08ca-e81f-5835-25f0559450be@oracle.com>
Date:   Tue, 15 Aug 2023 08:44:42 +0100
From:   John Garry <john.g.garry@...cle.com>
To:     Damien Le Moal <dlemoal@...nel.org>, jejb@...ux.ibm.com,
        martin.petersen@...cle.com, chenxiang66@...ilicon.com,
        artur.paszkiewicz@...el.com, yanaijie@...wei.com,
        jinpu.wang@...ud.ionos.com
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 07/10] scsi: libsas: Delete sas_ssp_task.task_prio

On 15/08/2023 03:17, Damien Le Moal wrote:
>> --- a/drivers/scsi/isci/request.c
>> +++ b/drivers/scsi/isci/request.c
>> @@ -180,7 +180,6 @@ static void sci_io_request_build_ssp_command_iu(struct isci_request *ireq)
>>   	cmd_iu->_r_a = 0;
>>   	cmd_iu->_r_b = 0;
>>   	cmd_iu->en_fburst = 0; /* unsupported */
>> -	cmd_iu->task_prio = task->ssp_task.task_prio;
> Shouldn't this be replaced with:
> 	
> 	cmd_iu->task_prio = 0;
> 
> ? (note sure how cmd_iu is being initialized, but given that the other fields
> around this code are assigned 0, I would guess this one needs that as well...)
> 

Yeah, I think that you are right - I'll fix that up. Thanks for checking 
very carefully.

John