[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <031fb6f3-4f5b-2b3b-bc12-afa3d10ae0f0@linux.alibaba.com>
Date: Tue, 15 Aug 2023 16:42:22 +0800
From: Baolin Wang <baolin.wang@...ux.alibaba.com>
To: Kemeng Shi <shikemeng@...weicloud.com>, linux-mm@...ck.org,
linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
mgorman@...hsingularity.net, david@...hat.com
Subject: Re: [PATCH 5/9] mm/compaction: remove repeat compact_blockskip_flush
check in reset_isolation_suitable
On 8/5/2023 7:07 PM, Kemeng Shi wrote:
> We have compact_blockskip_flush check in __reset_isolation_suitable, just
> remove repeat check before __reset_isolation_suitable in
> compact_blockskip_flush.
>
> Signed-off-by: Kemeng Shi <shikemeng@...weicloud.com>
Reviewed-by: Baolin Wang <baolin.wang@...ux.alibaba.com>
> ---
> mm/compaction.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/mm/compaction.c b/mm/compaction.c
> index 8d7d38073d30..d8416d3dd445 100644
> --- a/mm/compaction.c
> +++ b/mm/compaction.c
> @@ -434,9 +434,7 @@ void reset_isolation_suitable(pg_data_t *pgdat)
> if (!populated_zone(zone))
> continue;
>
> - /* Only flush if a full compaction finished recently */
> - if (zone->compact_blockskip_flush)
> - __reset_isolation_suitable(zone);
> + __reset_isolation_suitable(zone);
> }
> }
>
Powered by blists - more mailing lists