linux-kernel - Re: [PATCH 1/3] mips: remove unneeded #include <asm/export.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZNs2yBOYr57Rjq9t@alpha.franken.de>
Date:   Tue, 15 Aug 2023 10:26:48 +0200
From:   Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To:     Masahiro Yamada <masahiroy@...nel.org>
Cc:     linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arch@...r.kernel.org
Subject: Re: [PATCH 1/3] mips: remove unneeded #include <asm/export.h>

On Tue, Aug 08, 2023 at 12:32:41AM +0900, Masahiro Yamada wrote:
> There is no EXPORT_SYMBOL line there, hence #include <asm/export.h>
> is unneeded.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
> ---
> 
>  arch/mips/kernel/octeon_switch.S | 1 -
>  arch/mips/kernel/r2300_switch.S  | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/arch/mips/kernel/octeon_switch.S b/arch/mips/kernel/octeon_switch.S
> index 9b7c8ab6f08c..447a3ea14aa1 100644
> --- a/arch/mips/kernel/octeon_switch.S
> +++ b/arch/mips/kernel/octeon_switch.S
> @@ -11,7 +11,6 @@
>   *    written by Carsten Langgaard, carstenl@...s.com
>   */
>  #include <asm/asm.h>
> -#include <asm/export.h>
>  #include <asm/asm-offsets.h>
>  #include <asm/mipsregs.h>
>  #include <asm/regdef.h>
> diff --git a/arch/mips/kernel/r2300_switch.S b/arch/mips/kernel/r2300_switch.S
> index 71b1aafae1bb..48e63943e6f7 100644
> --- a/arch/mips/kernel/r2300_switch.S
> +++ b/arch/mips/kernel/r2300_switch.S
> @@ -13,7 +13,6 @@
>   */
>  #include <asm/asm.h>
>  #include <asm/cachectl.h>
> -#include <asm/export.h>
>  #include <asm/fpregdef.h>
>  #include <asm/mipsregs.h>
>  #include <asm/asm-offsets.h>
> -- 
> 2.39.2

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]