linux-kernel - Re: [PATCH 05/10] scsi: libsas: Delete sas_ssp_task.retry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2b83679c-1d17-3606-3ec9-01f384a760ee@huawei.com>
Date:   Tue, 15 Aug 2023 17:31:09 +0800
From:   Jason Yan <yanaijie@...wei.com>
To:     John Garry <john.g.garry@...cle.com>, <jejb@...ux.ibm.com>,
        <martin.petersen@...cle.com>, <chenxiang66@...ilicon.com>,
        <artur.paszkiewicz@...el.com>, <jinpu.wang@...ud.ionos.com>
CC:     <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <dlemoal@...nel.org>
Subject: Re: [PATCH 05/10] scsi: libsas: Delete sas_ssp_task.retry_count

On 2023/8/14 22:10, John Garry wrote:
> Since libsas was introduced in commit 2908d778ab3e ("[SCSI] aic94xx: new
> driver"), sas_ssp_task.retry_count is only ever set, so delete it.
> 
> The aic94xx driver also had its own retry_count definition in struct scb
> sub-structs, which may have caused a mix-up.
> 
> Signed-off-by: John Garry<john.g.garry@...cle.com>
> ---
>   drivers/scsi/libsas/sas_ata.c       | 1 -
>   drivers/scsi/libsas/sas_scsi_host.c | 1 -
>   include/scsi/libsas.h               | 2 --
>   3 files changed, 4 deletions(-)

Reviewed-by: Jason Yan <yanaijie@...wei.com>