[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <34c8ac7f-243f-ed15-6f93-3d153b6315b5@starfivetech.com>
Date: Tue, 15 Aug 2023 18:15:02 +0800
From: Minda Chen <minda.chen@...rfivetech.com>
To: Conor Dooley <conor.dooley@...rochip.com>
CC: Daire McNamara <daire.mcnamara@...rochip.com>,
Conor Dooley <conor@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Bjorn Helgaas <bhelgaas@...gle.com>,
Lorenzo Pieralisi <lpieralisi@...nel.org>,
Krzysztof Wilczyński <kw@...ux.com>,
Emil Renner Berthing <emil.renner.berthing@...onical.com>,
<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<linux-riscv@...ts.infradead.org>, <linux-pci@...r.kernel.org>,
Pali Rohár <pali@...nel.org>,
Paul Walmsley <paul.walmsley@...ive.com>,
Palmer Dabbelt <palmer@...belt.com>,
Albert Ou <aou@...s.berkeley.edu>,
Philipp Zabel <p.zabel@...gutronix.de>,
Mason Huo <mason.huo@...rfivetech.com>,
Leyfoon Tan <leyfoon.tan@...rfivetech.com>,
Kevin Xie <kevin.xie@...rfivetech.com>
Subject: Re: [PATCH v3 08/11] PCI: microchip: Move IRQ init functions to
pcie-plda-host.c
On 2023/8/14 21:57, Conor Dooley wrote:
> On Mon, Aug 14, 2023 at 04:20:13PM +0800, Minda Chen wrote:
>> Move IRQ init functions to pcie-plda-host.c. mc_handle_event
>> merge to plda_handle_event, Add get_events functions,
>> PolarFire PCIe uses get_events function pointer to get
>> their events num.
>
> Just a nit, could you add the () when referring to functions in
> changelogs please?
> Other than the comment I left on the last patch, this looks fine to me,
> but I'd definitely like Daire to take a look at these patches that
> modify the interrupt handling.
OK, Thanks.
Powered by blists - more mailing lists