linux-kernel - Re: [PATCH] rust: fix bindgen build error with fstrict-flex-arrays

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72nGurz9dJjy2p8q347vfsbaoAm8Jb5L4WAW0W2+5KZHOw@mail.gmail.com>
Date:   Tue, 15 Aug 2023 14:49:44 +0200
From:   Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To:     Andrea Righi <andrea.righi@...onical.com>
Cc:     Miguel Ojeda <ojeda@...nel.org>,
        Alex Gaynor <alex.gaynor@...il.com>,
        Wedson Almeida Filho <wedsonaf@...il.com>,
        Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
        Björn Roy Baron <bjorn3_gh@...tonmail.com>,
        Benno Lossin <benno.lossin@...ton.me>,
        "Gustavo A . R . Silva" <gustavoars@...nel.org>,
        Kees Cook <keescook@...omium.org>,
        Masahiro Yamada <masahiroy@...nel.org>,
        rust-for-linux@...r.kernel.org, linux-kbuild@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Nathan Chancellor <nathan@...nel.org>
Subject: Re: [PATCH] rust: fix bindgen build error with fstrict-flex-arrays

On Tue, Aug 15, 2023 at 2:44 PM Andrea Righi <andrea.righi@...onical.com> wrote:
>
> Oh yes, indeed! I'm using clang/libclang-14 with gcc-13, if I switch to
> clang-15 everything seems fine, so I can simply move to this version.

Thanks for confirming!

> The combo gcc-13 + libclang-15 seems to work in my case, instead with
> libclang-16 I get this:
>
>   BINDGEN rust/bindings/bindings_generated.rs
>   thread 'main' panicked at '"ftrace_branch_data_union_(anonymous_at__/_/include/linux/compiler_types_h_146_2)" is not a valid Ident', /build/rust-bindgen-0.56-DgAMvF/rust-bindgen-0.56-0.56.0/debian/vendor/proc-macro2-1.0.24/src/fallback.rs:693:9

Yeah, this is fixed in `bindgen` 0.62.0. We have upgraded in
`rust-next`, commit 08ab786556ff ("rust: bindgen: upgrade to 0.65.1").

Cheers,
Miguel