linux-kernel - Re: [PATCH v3 2/3] KVM: s390: Add UV feature negotiation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <464a84ad-bc8b-30be-3f20-8091a236113c@linux.ibm.com>
Date:   Tue, 15 Aug 2023 15:39:35 +0200
From:   Janosch Frank <frankja@...ux.ibm.com>
To:     Steffen Eiden <seiden@...ux.ibm.com>, linux-kernel@...r.kernel.org,
        linux-s390@...r.kernel.org, kvm@...r.kernel.org
Cc:     Claudio Imbrenda <imbrenda@...ux.ibm.com>,
        David Hildenbrand <david@...hat.com>,
        Michael Mueller <mimu@...ux.vnet.ibm.com>,
        Marc Hartmayer <mhartmay@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ux.ibm.com>
Subject: Re: [PATCH v3 2/3] KVM: s390: Add UV feature negotiation

On 8/10/23 13:32, Steffen Eiden wrote:
> Add a uv_feature list for pv-guests to the KVM cpu-model.
> The feature bits 'AP-interpretation for secure guests' and
> 'AP-interrupt for secure guests' are available.
> 
> Signed-off-by: Steffen Eiden <seiden@...ux.ibm.com>
[...]
>   
> +#define KVM_S390_VM_CPU_UV_FEAT_GUEST_DEFAULT 0

Reviewed-by: Janosch Frank <frankja@...ux.ibm.com>

I don't think that's needed, just set it to 0 (and even that's not 
really needed since it's kzalloced but I'm fine with making this explicit).

>   int kvm_arch_init_vm(struct kvm *kvm, unsigned long type)
>   {
>   	gfp_t alloc_flags = GFP_KERNEL_ACCOUNT;
> @@ -3296,6 +3368,8 @@ int kvm_arch_init_vm(struct kvm *kvm, unsigned long type)
>   	kvm->arch.model.cpuid = kvm_s390_get_initial_cpuid();
>   	kvm->arch.model.ibc = sclp.ibc & 0x0fff;
>   
> +	kvm->arch.model.uv_feat_guest.feat = KVM_S390_VM_CPU_UV_FEAT_GUEST_DEFAULT;
> +
>   	kvm_s390_crypto_init(kvm);
>   
>   	if (IS_ENABLED(CONFIG_VFIO_PCI_ZDEV_KVM)) {