linux-kernel - Re: [PATCH 08/25] ALSA: korg1212: Convert to generic PCM copy ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 15 Aug 2023 16:55:06 +0300
From:   Andy Shevchenko <andriy.shevchenko@...el.com>
To:     Takashi Iwai <tiwai@...e.de>
Cc:     alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 08/25] ALSA: korg1212: Convert to generic PCM copy ops

On Mon, Aug 14, 2023 at 01:55:06PM +0200, Takashi Iwai wrote:
> This patch converts the korg1212 driver code to use the new unified
> PCM copy callback.  The open-coded conditional memory copies are
> replaced with simpler copy_from/to_iter() calls.
> 
> Note that copy_from/to_iter() returns the copied bytes, hence the
> error condition is inverted from copy_from/to_user().

...

> +		if (!copy_to_iter(src, size, dst))

	!= size ?


>  			return -EFAULT;

...

> +		if (!copy_from_iter(dst, size, src))
>  			return -EFAULT;

Ditto.

-- 
With Best Regards,
Andy Shevchenko