linux-kernel - Re: [PATCH net v3] net: dsa: mv88e6xxx: Wait for EEPROM done before HW reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a7f0ffc1-eb12-4e76-8e0e-7adf40912d08@lunn.ch>
Date:   Tue, 15 Aug 2023 03:16:03 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Alfred Lee <l00g33k@...il.com>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        olteanv@...il.com, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, sgarzare@...hat.com,
        AVKrasnov@...rdevices.ru
Subject: Re: [PATCH net v3] net: dsa: mv88e6xxx: Wait for EEPROM done before
 HW reset

On Mon, Aug 14, 2023 at 05:13:23PM -0700, Alfred Lee wrote:
> If the switch is reset during active EEPROM transactions, as in
> just after an SoC reset after power up, the I2C bus transaction
> may be cut short leaving the EEPROM internal I2C state machine
> in the wrong state.  When the switch is reset again, the bad
> state machine state may result in data being read from the wrong
> memory location causing the switch to enter unexpected mode
> rendering it inoperational.

Hi Alfred

It is normal to place a history after the --- of what changed between
each version.

> Fixes: a3dcb3e7e70c ("net: dsa: mv88e6xxx: Wait for EEPROM done after HW reset")
> Signed-off-by: Alfred Lee <l00g33k@...il.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew