linux-kernel - Re: [PATCH net-next v6 5/6] page_pool: update document about frag API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 15 Aug 2023 08:12:47 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Yunsheng Lin <linyunsheng@...wei.com>, davem@...emloft.net,
        kuba@...nel.org, pabeni@...hat.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Lorenzo Bianconi <lorenzo@...nel.org>,
        Alexander Duyck <alexander.duyck@...il.com>,
        Liang Chen <liangchen.linux@...il.com>,
        Alexander Lobakin <aleksander.lobakin@...el.com>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        Ilias Apalodimas <ilias.apalodimas@...aro.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Jonathan Corbet <corbet@....net>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        John Fastabend <john.fastabend@...il.com>,
        linux-doc@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [PATCH net-next v6 5/6] page_pool: update document about frag API



On 8/15/23 05:24, Yunsheng Lin wrote:
> On 2023/8/15 6:42, Randy Dunlap wrote:
>> Hi--
> Thanks for the reviewing.
> 
> ...
> 
>>> @@ -100,6 +115,14 @@ static inline struct page *page_pool_alloc_frag(struct page_pool *pool,
>>>       return __page_pool_alloc_frag(pool, offset, size, gfp);
>>>   }
>>>   +/**
>>> + * page_pool_dev_alloc_frag() - allocate a page frag.
>>> + * @pool[in]    pool from which to allocate
>>> + * @offset[out]    offset to the allocated page
>>> + * @size[in]    requested size
>> Please use kernel-doc syntax/notation here.
> Will change to:

Thanks. Those look good.

-- 
~Randy