linux-kernel - Re: [PATCH V2 1/7] x86: Drop CPU_SUP_INTEL from SCHED_MC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dca26c63-9a89-4be0-aa60-6dc99b7927d0@amd.com>
Date:   Tue, 15 Aug 2023 10:20:02 -0500
From:   Mario Limonciello <mario.limonciello@....com>
To:     Meng Li <li.meng@....com>,
        "Rafael J . Wysocki" <rafael.j.wysocki@...el.com>,
        Huang Rui <ray.huang@....com>
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        x86@...nel.org, linux-acpi@...r.kernel.org,
        Shuah Khan <skhan@...uxfoundation.org>,
        linux-kselftest@...r.kernel.org,
        Nathan Fontenot <nathan.fontenot@....com>,
        Deepak Sharma <deepak.sharma@....com>,
        Alex Deucher <alexander.deucher@....com>,
        Shimmer Huang <shimmer.huang@....com>,
        Perry Yuan <Perry.Yuan@....com>,
        Xiaojian Du <Xiaojian.Du@....com>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        Borislav Petkov <bp@...en8.de>
Subject: Re: [PATCH V2 1/7] x86: Drop CPU_SUP_INTEL from SCHED_MC_PRIO for the
 expansion.

On 8/15/2023 01:15, Meng Li wrote:
> Drop CPU_SUP_INTE from SCHED_MC_PRIO, and it can be used by X86_AMD_PSTATE.

s/CPU_SUP_INTE/CPU_SUP_INTEL/

Also I think this should have a wider description.

Something like:

"amd-pstate also uses SCHED_MC_PRIO, so decouple the requirement
of CPU_SUP_INTEL from the dependencies to allow compilation in kernels 
without Intel CPU support."

> 
> Signed-off-by: Meng Li <li.meng@....com>
> ---
>   arch/x86/Kconfig | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index e36261b4ea14..03322d2840fa 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -1052,8 +1052,9 @@ config SCHED_MC
>   
>   config SCHED_MC_PRIO
>   	bool "CPU core priorities scheduler support"
> -	depends on SCHED_MC && CPU_SUP_INTEL
> +	depends on SCHED_MC
>   	select X86_INTEL_PSTATE
> +	select X86_AMD_PSTATE

Thinking about it further I wonder if what we actually want is
something like this:

select X86_INTEL_PSTATE if CPU_SUP_INTEL
select X86_INTEL_PSTATE if CPU_SUP_AMD

Then it will work functionally the same for Intel systems
but now you can compile the kernel with support for one
or both and get the right combination included.

>   	select CPU_FREQ
>   	default y
>   	help