[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZNuetxBBXX2bsoJ+@smile.fi.intel.com>
Date: Tue, 15 Aug 2023 18:50:15 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc: Wolfram Sang <wsa@...nel.org>, Andi Shyti <andi.shyti@...nel.org>,
Biju Das <biju.das.jz@...renesas.com>,
Jonathan Cameron <jic23@...nel.org>,
Michael Hennerich <michael.hennerich@...log.com>,
Peter Rosin <peda@...ntia.se>, linux-i2c@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFC 2/4] i2c: mux: ltc4306: convert to using a pointer in
i2c_device_id
On Mon, Aug 14, 2023 at 02:52:50PM -0700, Dmitry Torokhov wrote:
> Switch the driver to use newly added "data" pointer in i2c_device_id to
> streamline DT and legacy flows.
...
> chip = of_device_get_match_data(&client->dev);
> -
> if (!chip)
> - chip = &chips[i2c_match_id(ltc4306_id, client)->driver_data];
> + chip = i2c_match_id(ltc4306_id, client)->data;
The whole thing can be converted to i2c_device_get_match_data() with the new
helper from another thread. That said, I don't see value in this half-baked
change.
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists