linux-kernel - Re: [PATCH v2] accel/qaic: Fix slicing memory leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <40b670e1-dea0-8c0c-8605-9067503d100a@quicinc.com>
Date:   Tue, 15 Aug 2023 09:55:03 -0600
From:   Jeffrey Hugo <quic_jhugo@...cinc.com>
To:     <dri-devel@...ts.freedesktop.org>
CC:     <ogabbay@...nel.org>, <jacek.lawrynowicz@...ux.intel.com>,
        <stanislaw.gruszka@...ux.intel.com>, <quic_carlv@...cinc.com>,
        <quic_ajitpals@...cinc.com>, <linux-arm-msm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <Markus.Elfring@....de>,
        "Pranjal Ramajor Asha Kanojiya" <quic_pkanojiy@...cinc.com>
Subject: Re: [PATCH v2] accel/qaic: Fix slicing memory leak

On 8/2/2023 8:59 AM, Jeffrey Hugo wrote:
> From: Pranjal Ramajor Asha Kanojiya <quic_pkanojiy@...cinc.com>
> 
> The temporary buffer storing slicing configuration data from user is only
> freed on error.  This is a memory leak.  Free the buffer unconditionally.
> 
> Fixes: ff13be830333 ("accel/qaic: Add datapath")
> Signed-off-by: Pranjal Ramajor Asha Kanojiya <quic_pkanojiy@...cinc.com>
> Reviewed-by: Carl Vanderlip <quic_carlv@...cinc.com>
> Reviewed-by: Jeffrey Hugo <quic_jhugo@...cinc.com>
> Signed-off-by: Jeffrey Hugo <quic_jhugo@...cinc.com>

Pushed to drm-misc-fixes.

-Jeff