[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ZNuwJVSJy0Uy0zPN@smile.fi.intel.com>
Date: Tue, 15 Aug 2023 20:04:37 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Marcus Folkesson <marcus.folkesson@...il.com>
Cc: Kent Gustavsson <kent@...oris.se>,
Jonathan Cameron <jic23@...nel.org>,
Lars-Peter Clausen <lars@...afoo.de>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Cosmin Tanislav <demonsingur@...il.com>,
Arnd Bergmann <arnd@...db.de>,
ChiYuan Huang <cy_huang@...htek.com>,
Haibo Chen <haibo.chen@....com>,
Ramona Bolboaca <ramona.bolboaca@...log.com>,
Ibrahim Tilki <Ibrahim.Tilki@...log.com>,
ChiaEn Wu <chiaen_wu@...htek.com>,
William Breathitt Gray <william.gray@...aro.org>,
linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 4/6] iio: adc: mcp3911: fix indentation
On Tue, Aug 15, 2023 at 06:55:45PM +0200, Marcus Folkesson wrote:
> On Tue, Aug 15, 2023 at 05:58:13PM +0300, Andy Shevchenko wrote:
> > On Mon, Aug 14, 2023 at 02:10:08PM +0200, Marcus Folkesson wrote:
> > > The file does not make use of indentation properly.
> >
> > > Fix that.
> >
> > I'm not sure this is anyhow a fix. Yet you may refer to the checkpatch
> > if it complains.
> >
> > ...
> >
> > This kind of change is preferred to be the last in the series or closer
> > to the end where no more code changed.
>
> Checkpatch did never complain about the formatting, but I got a few comments
> during the review process about the formatting, so I went
> through the whole file to fix it once for all.
>
> I do not think that it has to be the last patch in the series.
> All following patches has proper indentation.
> Pretty much the same as the simplification of spi->dev I think.
>
> If there is no strong opinions about it I think I will leave it as is.
I'm not a maintainer of IIO, so let them decide :-)
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists