linux-kernel - Re: [PATCH v1] kernel: auditsc: Removes use of assignment in if condition and moves open brace following function definitions to the next line.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230816025839.GE57274@atom0118>
Date:   Wed, 16 Aug 2023 08:28:39 +0530
From:   Atul Kumar Pant <atulpant.linux@...il.com>
To:     Paul Moore <paul@...l-moore.com>
Cc:     eparis@...hat.com, audit@...r.kernel.org,
        linux-kernel@...r.kernel.org, shuah@...nel.org
Subject: Re: [PATCH v1] kernel: auditsc: Removes use of assignment in if
 condition and moves open brace following function definitions to the next
 line.

On Tue, Aug 15, 2023 at 06:14:25PM -0400, Paul Moore wrote:
> On Tue, Aug 15, 2023 at 6:10 PM Paul Moore <paul@...l-moore.com> wrote:
> >
> > On Aug 15, 2023 Atul Kumar Pant <atulpant.linux@...il.com> wrote:
> > >
> > > The patch fixes following checkpatch.pl issue:
> > > ERROR: open brace '{' following function definitions go on the next line
> > > ERROR: do not use assignment in if condition
> > >
> > > Signed-off-by: Atul Kumar Pant <atulpant.linux@...il.com>
> > > ---
> > >  kernel/auditsc.c | 6 ++++--
> > >  1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > Merged into audit/next, thanks.
> 
> I also wanted to say that I changed the subject line to "audit:
> cleanup function braces and assignment-in-if-condition", what you had
> written was far too long for a subject line.  A subject line should be
> brief and does not need to be a full sentence, in fact it probably
> should *not* be a full sentence.
> 
	Thank you for the comments. I agree with your point on subject line
	and will follow your advice in my next patches.

> -- 
> paul-moore.com