[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <eaed15ca-5c0b-420e-a11e-007ef5608019@linaro.org>
Date: Wed, 16 Aug 2023 19:20:48 +0200
From: Konrad Dybcio <konrad.dybcio@...aro.org>
To: Bryan O'Donoghue <bryan.odonoghue@...aro.org>, rfoss@...nel.org,
todor.too@...il.com, agross@...nel.org, andersson@...nel.org,
mchehab@...nel.org, hverkuil-cisco@...all.nl,
laurent.pinchart@...asonboard.com, sakari.ailus@...ux.intel.com,
andrey.konovalov@...aro.org
Cc: linux-media@...r.kernel.org, linux-arm-msm@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 04/14] media: qcom: camss: Pass icc bandwidth table as
a platform parameter
On 14.08.2023 18:28, Bryan O'Donoghue wrote:
> Pass the bandwidth table as a platform parameter not if/else derived
> pointer to the static table.
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
> ---
> drivers/media/platform/qcom/camss/camss.c | 29 +++++++----------------
> drivers/media/platform/qcom/camss/camss.h | 3 ++-
> 2 files changed, 11 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c
> index 68eb45b2c0aaa..1a195eb4298a5 100644
> --- a/drivers/media/platform/qcom/camss/camss.c
> +++ b/drivers/media/platform/qcom/camss/camss.c
> @@ -1484,21 +1484,15 @@ static int camss_configure_pd(struct camss *camss)
> static int camss_icc_get(struct camss *camss)
> {
> const struct resources_icc *icc_res;
> - int nbr_icc_paths = 0;
> int i;
>
> - if (camss->version == CAMSS_8250) {
> - icc_res = &icc_res_sm8250[0];
> - nbr_icc_paths = ICC_SM8250_COUNT;
> - }
> + icc_res = camss->res->icc_res;
Would initializing at declaration time fit in 100 chars?
lgtm otherwise
Konrad
Powered by blists - more mailing lists