linux-kernel - Re: [PATCH v10 2/2] Input: Add Novatek NT36xxx touchscreen driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 16 Aug 2023 19:36:10 +0200
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Joel Selvaraj <joelselvaraj.oss@...il.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Henrik Rydberg <rydberg@...math.org>
Cc:     Marijn Suijten <marijn.suijten@...ainline.org>,
        linux-input@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, Dang Huynh <danct12@...eup.net>,
        Amit Pundir <amit.pundir@...aro.org>
Subject: Re: [PATCH v10 2/2] Input: Add Novatek NT36xxx touchscreen driver

On 16.08.2023 03:09, Joel Selvaraj wrote:
> Hi Konrad Dybcio,
> 
> On 8/8/23 18:38, Konrad Dybcio wrote:
>> From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
>>
>> This is a driver for the Novatek in-cell touch controller and
>> supports various chips from the NT36xxx family, currently
>> including NT36525, NT36672A, NT36676F, NT36772 and NT36870.
> 
> In kernel v6.4, a basic novatek touchscreen driver was introduced [1].
> I was able to tweak IT a bit (add devicetree compatible, regulator support, remove chip id hardcode) and get it properly working in my Xiaomi Poco F1 which has Novatek NT36672A touchscreen. Probably the other ICs will also work. So, do we really need a separate touchscreen driver? Maybe the existing one can be improved to add more features if needed?
Do you have your end outcome somewhere?

I can take a look and compare if anything's missing..


> 
> Personally I have been looking forward to the v10 of this patchseries :) Thanks for working on this! But, yeah, we need to decide if we need this to be a separate driver.
We'll see, I was hoping I could add firmware loading, SPI transport and
eventually pen support..

Konrad