linux-kernel - Re: [PATCH v2 5/6] clk: qcom: videocc-sm8550: Use HW_CTRL_TRIGGER instead of HW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f66dabb9-1068-40d0-9a73-b59f1cdf90e0@linaro.org>
Date:   Wed, 16 Aug 2023 19:57:25 +0200
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Abel Vesa <abel.vesa@...aro.org>,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        Kevin Hilman <khilman@...nel.org>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Pavel Machek <pavel@....cz>, Len Brown <len.brown@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Andy Gross <agross@...nel.org>,
        Mike Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Taniya Das <tdas@....qualcomm.com>
Cc:     linux-pm@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-arm-msm@...r.kernel.org,
        Jagadeesh Kona <quic_jkona@...cinc.com>
Subject: Re: [PATCH v2 5/6] clk: qcom: videocc-sm8550: Use HW_CTRL_TRIGGER
 instead of HW_CTRL for GDSC

On 16.08.2023 16:57, Abel Vesa wrote:
> From: Jagadeesh Kona <quic_jkona@...cinc.com>
> 
> HW_CTRL moves the GDSC to HW control mode as part of GDSC enable itself.
> Use HW_CTRL_TRIGGER flag instead of HW_CTRL flag for video GDSC's to
> switch the GDSC to HW/SW control modes only when consumer requested to
> switch GDSC mode using dev_pm_genpd_set_hwmode.
> 
> Signed-off-by: Jagadeesh Kona <quic_jkona@...cinc.com>
> ---
Any reason for it to be a separate patch?

I'd say either keep all changes separate (for easier bisecting) or keep
them all in a single commit.

Konrad