linux-kernel - Re: [PATCH V1 2/2] phy: qcom-qmp-ufs: Add Phy Configuration support for SC7280

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <538aa051-e263-4ae5-bd32-9e3d106701d8@linaro.org>
Date:   Wed, 16 Aug 2023 20:13:30 +0200
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Nitin Rawat <quic_nitirawa@...cinc.com>, andersson@...nel.org,
        vkoul@...nel.org, agross@...nel.org, kishon@...nel.org
Cc:     linux-arm-msm@...r.kernel.org, linux-phy@...ts.infradead.org,
        linux-kernel@...r.kernel.org, Manish Pandey <quic_mapa@...cinc.com>
Subject: Re: [PATCH V1 2/2] phy: qcom-qmp-ufs: Add Phy Configuration support
 for SC7280

On 16.08.2023 20:12, Konrad Dybcio wrote:
> On 16.08.2023 17:48, Nitin Rawat wrote:
>> Add SC7280 specific register layout and table configs.
>>
>> Co-developed-by: Manish Pandey <quic_mapa@...cinc.com>
>> Signed-off-by: Manish Pandey <quic_mapa@...cinc.com>
>> Signed-off-by: Nitin Rawat <quic_nitirawa@...cinc.com>
>> ---
> Looks very reasonable compared to what I can see downstream.
> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>
I guess one nit I'd add is that having the compatible list sorted
alphanumerically would be a nice touch

Konrad