linux-kernel - Re: [PATCH] fsi: i2cr: Switch to use struct i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1b841ade-20c0-d239-d8ae-2bb4426fefa8@linux.ibm.com>
Date:   Wed, 16 Aug 2023 13:33:01 -0500
From:   Eddie James <eajames@...ux.ibm.com>
To:     Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
        Joel Stanley <joel@....id.au>, Jeremy Kerr <jk@...abs.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Alistar Popple <alistair@...ple.id.au>, linux-fsi@...ts.ozlabs.org,
        kernel@...gutronix.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fsi: i2cr: Switch to use struct i2c_driver's .probe()


On 8/16/23 12:19, Uwe Kleine-König wrote:
> struct i2c_driver::probe_new is about to go away. Switch the driver to
> use the probe callback with the same prototype.


Thanks!


Reviewed-by: Eddie James <eajames@...ux.ibm.com>


>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> ---
> Hello,
>
> this driver appeared in next just today. I intend to drop .probe_new
> from struct i2c_driver after v6.6-rc1, so it would be great if this
> patch would go in together with the commit adding this driver.
>
> Thanks
> Uwe
>
>   drivers/fsi/fsi-master-i2cr.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fsi/fsi-master-i2cr.c b/drivers/fsi/fsi-master-i2cr.c
> index 61659c27a973..40f1f4d231e5 100644
> --- a/drivers/fsi/fsi-master-i2cr.c
> +++ b/drivers/fsi/fsi-master-i2cr.c
> @@ -301,7 +301,7 @@ static const struct of_device_id i2cr_ids[] = {
>   MODULE_DEVICE_TABLE(of, i2cr_ids);
>   
>   static struct i2c_driver i2cr_driver = {
> -	.probe_new = i2cr_probe,
> +	.probe = i2cr_probe,
>   	.remove = i2cr_remove,
>   	.driver = {
>   		.name = "fsi-master-i2cr",
>
> base-commit: 53e89e3e4490d6630a68e61a3cb478e7a7f2ce8b