linux-kernel - Re: [PATCH RFC v3] mm: Proper document tail pages fields for folio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bade83ec-1617-1efa-6146-fa179a796174@redhat.com>
Date:   Wed, 16 Aug 2023 20:59:32 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Peter Xu <peterx@...hat.com>
Cc:     linux-kernel@...r.kernel.org, Matthew Wilcox <willy@...radead.org>,
        linux-mm@...ck.org, Hugh Dickins <hughd@...gle.com>,
        "Kirill A . Shutemov" <kirill@...temov.name>,
        Randy Dunlap <rdunlap@...radead.org>,
        Mike Kravetz <mike.kravetz@...cle.com>,
        Yu Zhao <yuzhao@...gle.com>,
        Ryan Roberts <ryan.roberts@....com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Yang Shi <shy828301@...il.com>
Subject: Re: [PATCH RFC v3] mm: Proper document tail pages fields for folio

>>   	do {
>>   		xas_lock_irq(&xas);
>> @@ -113,7 +114,6 @@ int add_to_swap_cache(struct folio *folio, swp_entry_t entry,
>>   				if (shadowp)
>>   					*shadowp = old;
>>   			}
>> -			set_page_private(folio_page(folio, i), entry.val + i);
>>   			xas_store(&xas, folio);
>>   			xas_next(&xas);
>>   		}
>> @@ -154,9 +154,9 @@ void __delete_from_swap_cache(struct folio *folio,
>>   	for (i = 0; i < nr; i++) {
>>   		void *entry = xas_store(&xas, shadow);
>>   		VM_BUG_ON_PAGE(entry != folio, entry);
>> -		set_page_private(folio_page(folio, i), 0);
>>   		xas_next(&xas);
>>   	}
>> +	folio->private = 0;
> 
> I'd rather remove all direct reference to "private" for swap alongside, if
> this would be the last spot (perhaps folio_set_swap_entry()).

Good idea, thanks!

-- 
Cheers,

David / dhildenb