linux-kernel - Re: [PATCH v7 7/8] x86/resctrl: Introduce "-o debug" mount option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <307e6672-6778-bc32-c5fc-64ddc74de2cc@amd.com>
Date:   Wed, 16 Aug 2023 14:15:14 -0500
From:   "Moger, Babu" <babu.moger@....com>
To:     Reinette Chatre <reinette.chatre@...el.com>, corbet@....net,
        tglx@...utronix.de, mingo@...hat.com, bp@...en8.de
Cc:     fenghua.yu@...el.com, dave.hansen@...ux.intel.com, x86@...nel.org,
        hpa@...or.com, paulmck@...nel.org, akpm@...ux-foundation.org,
        quic_neeraju@...cinc.com, rdunlap@...radead.org,
        damien.lemoal@...nsource.wdc.com, songmuchun@...edance.com,
        peterz@...radead.org, jpoimboe@...nel.org, pbonzini@...hat.com,
        chang.seok.bae@...el.com, pawan.kumar.gupta@...ux.intel.com,
        jmattson@...gle.com, daniel.sneddon@...ux.intel.com,
        sandipan.das@....com, tony.luck@...el.com, james.morse@....com,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
        bagasdotme@...il.com, eranian@...gle.com,
        christophe.leroy@...roup.eu, jarkko@...nel.org,
        adrian.hunter@...el.com, quic_jiles@...cinc.com,
        peternewman@...gle.com
Subject: Re: [PATCH v7 7/8] x86/resctrl: Introduce "-o debug" mount option

Hi Reinette,

On 8/15/23 17:51, Reinette Chatre wrote:
> Hi Babu,
> 
> On 8/11/2023 1:10 PM, Babu Moger wrote:
> 
> ...
> 
>> @@ -2833,6 +2849,8 @@ static void rdt_kill_sb(struct super_block *sb)
>>  
>>  	set_mba_sc(false);
>>  
>> +	resctrl_debug = false;
>> +
>>  	/*Put everything back to default values. */
>>  	for_each_alloc_capable_rdt_resource(r)
>>  		reset_all_ctrls(r);
> 
> This should not be necessary as rdt_disable_ctx() should already
> be called here.

Yes. Sure.

-- 
Thanks
Babu Moger