linux-kernel - Re: [PATCH -next] KEYS: Remove unused declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <CUU9WXZGDDO2.2E7XP03ITLLLY@suppilovahvero>
Date:   Thu, 17 Aug 2023 00:06:09 +0300
From:   "Jarkko Sakkinen" <jarkko@...nel.org>
To:     "Yue Haibing" <yuehaibing@...wei.com>, <dhowells@...hat.com>
Cc:     <keyrings@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] KEYS: Remove unused declarations

On Wed Aug 16, 2023 at 4:11 PM EEST, Yue Haibing wrote:
> These declarations are never implemented, remove it.
>
> Signed-off-by: Yue Haibing <yuehaibing@...wei.com>
> ---
>  include/keys/dns_resolver-type.h | 4 ----
>  include/linux/key.h              | 3 ---
>  2 files changed, 7 deletions(-)
>
> diff --git a/include/keys/dns_resolver-type.h b/include/keys/dns_resolver-type.h
> index 218ca22fb056..1b89088a2837 100644
> --- a/include/keys/dns_resolver-type.h
> +++ b/include/keys/dns_resolver-type.h
> @@ -12,8 +12,4 @@
>  
>  extern struct key_type key_type_dns_resolver;
>  
> -extern int request_dns_resolver_key(const char *description,
> -				    const char *callout_info,
> -				    char **data);
> -
>  #endif /* _KEYS_DNS_RESOLVER_TYPE_H */
> diff --git a/include/linux/key.h b/include/linux/key.h
> index 938d7ecfb495..f16deadebca9 100644
> --- a/include/linux/key.h
> +++ b/include/linux/key.h
> @@ -436,9 +436,6 @@ extern key_ref_t keyring_search(key_ref_t keyring,
>  				const char *description,
>  				bool recurse);
>  
> -extern int keyring_add_key(struct key *keyring,
> -			   struct key *key);
> -
>  extern int keyring_restrict(key_ref_t keyring, const char *type,
>  			    const char *restriction);
>  
> -- 
> 2.34.1

Acked-by: Jarkko Sakkinen <jarkko@...nel.org>

David, can you pick this one?

BR, Jarkko