[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230816033418.GD681074@google.com>
Date: Wed, 16 Aug 2023 12:34:18 +0900
From: Sergey Senozhatsky <senozhatsky@...omium.org>
To: "Leizhen (ThunderTown)" <thunder.leizhen@...weicloud.com>
Cc: Petr Mladek <pmladek@...e.com>,
Sergey Senozhatsky <senozhatsky@...omium.org>,
Steven Rostedt <rostedt@...dmis.org>,
John Ogness <john.ogness@...utronix.de>,
linux-kernel@...r.kernel.org,
Zhen Lei <thunder.leizhen@...wei.com>,
Randy Dunlap <rdunlap@...radead.org>,
Kees Cook <keescook@...omium.org>,
linux-hardening@...r.kernel.org
Subject: Re: [PATCH v3 2/2] hexdump: add a new dump prefix DUMP_PREFIX_CUSTOM
On (23/08/16 11:20), Leizhen (ThunderTown) wrote:
> > IMHO, this is pretty bad interface.
> >
> > + From the user POV:
> >
> > It is far from clear what values will be passed for the given
> > printf format. It can be docummented but...
> >
> >
> > + From the security POV:
> >
> > The compiler could not check if the printk() parameters
> > match the format. I mean if the number of types of
> > the parameters are correct.
>
> Yes, it has these problems. So, back to v2, how about add DUMP_PREFIX_ADDRESS_LOW16?
> Or named DUMP_PREFIX_ADDR16 or others. Or change the format of DUMP_PREFIX_ADDRESS
> from "%p" to "%px",Or add DUMP_PREFIX_RAWADDR. Or keep the status quo.
Linus quite likely will dislike (with passion) the idea of using %px.
Powered by blists - more mailing lists