linux-kernel - Re: [PATCH v1 1/1] scsi: ufs: mcq: Fix the search/wrap around logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <de179ae2-0d26-79f4-b689-cb038099a5e7@acm.org>
Date:   Wed, 16 Aug 2023 16:45:30 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     "Bao D. Nguyen" <quic_nguyenb@...cinc.com>, quic_cang@...cinc.com,
        quic_nitirawa@...cinc.com, avri.altman@....com, beanhuo@...ron.com,
        stanley.chu@...iatek.com, adrian.hunter@...el.com,
        martin.petersen@...cle.com
Cc:     linux-scsi@...r.kernel.org, Alim Akhtar <alim.akhtar@...sung.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        Manivannan Sadhasivam <mani@...nel.org>,
        Asutosh Das <quic_asutoshd@...cinc.com>,
        Po-Wen Kao <powen.kao@...iatek.com>,
        Yang Li <yang.lee@...ux.alibaba.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 1/1] scsi: ufs: mcq: Fix the search/wrap around logic

On 8/15/23 18:38, Bao D. Nguyen wrote:
> The search and wrap around logic in the ufshcd_mcq_sqe_search()
> function does not work correctly when the hwq's queue depth
> is not a power of two number. Correct it so that any queue depth
> with a positive integer value within the supported range would work.

Does this patch need a Fixes: tag?

Anyway:

Reviewed-by: Bart Van Assche <bvanassche@....org>